sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Review Request 26609: SQOOP-1576 Sqoop2: Validations: Migrate Repository upgrade to the new validator infrastructure
Date Sat, 11 Oct 2014 21:51:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26609/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1576
    https://issues.apache.org/jira/browse/SQOOP-1576


Repository: sqoop-sqoop2


Description
-------

I've migrated Repository validation structure to the new infra. I've noticed some code reuse
between Repository and Server Handlers, so I've refactored those to ConfigUtils class.


Diffs
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 9e762dc 
  common/src/main/java/org/apache/sqoop/model/ModelError.java 35a8943 
  common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java d5377f8 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 

Diff: https://reviews.apache.org/r/26609/diff/


Testing
-------

Unit tests seems to be passing.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message