sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service
Date Thu, 16 Oct 2014 19:46:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26678/#review56962
-----------------------------------------------------------


Looking better!


core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java
<https://reviews.apache.org/r/26678/#comment97401>

    I was thinking... Does it also make sense for this class to handle both responsibilities
of understanding how to authenticate and when to authenticate? Splitting it up might make
developing new ways to authenticate easier.



core/src/main/java/org/apache/sqoop/authentication/AuthenticationManagerFactory.java
<https://reviews.apache.org/r/26678/#comment97402>

    NIT: if ... else if ... else?


- Abraham Elmahrek


On Oct. 16, 2014, 2:35 p.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26678/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 2:35 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Kerberos support when starting service
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationManagerFactory.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationManager.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationManager.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java ac836c7cee010144696ab17645ccd008aed5762d

>   dist/src/main/server/conf/sqoop.properties bb010166120321899425f84edb8e1ad6512626d2

>   pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 
> 
> Diff: https://reviews.apache.org/r/26678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message