> On Oct. 17, 2014, 2:55 p.m., Qian Xu wrote:
> > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java,
line 62
> > <https://reviews.apache.org/r/26581/diff/1-2/?file=718066#file718066line62>
> >
> > How about considering the deprecation suggestion?
> >
> > > Constructing HBaseAdmin objects manually has been deprecated. Use Connection.getAdmin()
to obtain an instance of Admin instead.
>
> Abraham Elmahrek wrote:
> I'm not 100% sure on this one: https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HConnection.html.
`HConnection.getAdmin` seems deprecated. It seems like the APIs are in the process of changing.
Let's keep this for now since the API isn't deprecated in the latest stable release (https://github.com/apache/hbase/blob/0.99.1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java#L195)?
Okay, then no change is required. Note that I'm not sure if creating `HBaseAdmin` too frequently
will leak memory. I'd once massive memory leaks on production environment 20 days after service
startup. Leaks were caused in `admin.close()`. Internal reference counting was not decremented.
Do not remember if the hbase jars are the original or home made.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/#review57115
-----------------------------------------------------------
On Oct. 17, 2014, 2:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26581/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1156
> https://issues.apache.org/jira/browse/SQOOP-1156
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
> Author: Abraham Elmahrek <abraham@elmahrek.com>
> Date: Thu Oct 9 22:56:34 2014 -0700
>
> SQOOP-1156: HBase connector
>
> :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml
> :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
> :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
> :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
> :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
> :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
> :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
> :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
> :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
> :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
> :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
> :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
> :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
> :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
> :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties
> :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
> :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
> :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties
> :100644 100644 e98a0fc... 35c665e... M connector/pom.xml
> :100644 100644 f25a29f... a556bcf... M pom.xml
> :100644 100644 67baaa5... 21a1fa9... M server/pom.xml
> :100644 100644 7a80710... fbd4e84... M test/pom.xml
>
>
> Diffs
> -----
>
> connector/connector-hbase/pom.xml PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
PRE-CREATION
> connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
PRE-CREATION
> connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION
> connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
PRE-CREATION
> connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
PRE-CREATION
> connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26581/diff/
>
>
> Testing
> -------
>
> mvn clean verify + can transfer from mysql to hbase.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
|