> On Oct. 17, 2014, 10:10 p.m., Qian Xu wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java,
line 72
> > <https://reviews.apache.org/r/26880/diff/2/?file=724537#file724537line72>
> >
> > The doUpgrade code appears multiple times in code. Better create a follow-up
jira to move this code into its superclass.
Thats a very good observation. I found the same with other parts of the connectors code as
well, between the driver and connector a lot of the configuration classes can be shared, instead
they are copy pasted, thanks for the input, I will move it to a util class
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26880/#review57263
-----------------------------------------------------------
On Oct. 17, 2014, 11:08 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26880/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 11:08 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> #1 - + 1 from Jarek Jarcec Cecho, we shall call it ConfigurableUpgrader
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191
> common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
87ac2af
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
a069b3e
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
b17aa21
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
606b9fa
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java
PRE-CREATION
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926
> core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb
> core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 9c3b660
> core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab
> core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java d4e2254
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/repository/Repository.java 74a9e12
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 34bd8a5
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
c888910
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
44ec2e3
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java a1bc5d5
> spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION
> spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 5315e1f
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 76ebd3b
>
> Diff: https://reviews.apache.org/r/26880/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
|