sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 26941: SQOOP-1557: SQ_CONFIGURABLE ( for entities who own configs)
Date Mon, 20 Oct 2014 18:29:19 GMT


> On Oct. 20, 2014, 11:26 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/MDriver.java, lines 71-73
> > <https://reviews.apache.org/r/26941/diff/1/?file=725833#file725833line71>
> >
> >     Why returning String, wouldn't it make more sense to return the enumb MConfigurableType
directly?

this method is most used to persist the value in database. I dont like hardcoding int he derby,
like most other places have done esp cial for the config types.

If we have more repository implementaitons tomm, we can just use the getType method.


> On Oct. 20, 2014, 11:26 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/MConnector.java, line 20
> > <https://reviews.apache.org/r/26941/diff/1/?file=725832#file725832line20>
> >
> >     Seems as irrelevant import?

I have no idea why this happens:) fixed


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26941/#review57377
-----------------------------------------------------------


On Oct. 20, 2014, 11:27 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26941/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 11:27 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA for details
> 
> there is whitespace, that will be addressed once the reviews for the functionality
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
3e4a4a9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
c888910 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
59773e1 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
44ec2e3 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
366e4ee 
> 
> Diff: https://reviews.apache.org/r/26941/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message