> On Oct. 20, 2014, 4:06 p.m., Veena Basavaraj wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java,
line 194
> > <https://reviews.apache.org/r/26941/diff/1/?file=725835#file725835line194>
> >
> > I have fixed this, but I was curious to know if this is a standard style? or
a personal preference.
>
> Jarek Cecho wrote:
> The reason is to enable better use of "git cherrypick" and "git blame", so that by
adding new error exception you don't have to alter unrelated line before.
ah. ! light bulb.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26941/#review57441
-----------------------------------------------------------
On Oct. 20, 2014, 11:27 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26941/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 11:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details
>
> there is whitespace, that will be addressed once the reviews for the functionality
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191
> common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e
> core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
3e4a4a9
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
c888910
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
59773e1
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
44ec2e3
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
366e4ee
>
> Diff: https://reviews.apache.org/r/26941/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
|