sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <sx.a...@googlemail.com>
Subject Re: Review Request 26931: SQOOP-1527: Kerberos support (SPNEGO) in communication between server and client
Date Tue, 21 Oct 2014 04:05:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26931/#review57539
-----------------------------------------------------------



client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
<https://reviews.apache.org/r/26931/#comment98289>

    use existing enum of http methods would be better than using string constants.



client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
<https://reviews.apache.org/r/26931/#comment98288>

    remove `""+`



client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
<https://reviews.apache.org/r/26931/#comment98291>

    Any garantee of closing DataOutputStream object?



client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
<https://reviews.apache.org/r/26931/#comment98293>

    Any garantee of closing BufferedReader?



client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
<https://reviews.apache.org/r/26931/#comment98286>

    if use `trace` for error messages? so nobody gonna see these error messages.


- Qian Xu


On Oct. 20, 2014, 10:56 p.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26931/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 10:56 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> SQOOP-1527: Kerberos support (SPNEGO) in communication between server and client
> This is an initial patch.
> This patch depends on SQOOP-1526, which is under reviewing (https://reviews.apache.org/r/26678/diff/#)
> 
> 
> Diffs
> -----
> 
>   client/pom.xml b2e221ec3b5398c05fa081989e73cf1f2c4d43e5 
>   client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java c84a83e3fd7c550645bda8cf5a0ecc844ef7721d

>   server/pom.xml 67baaa57da9f69f2e8795107ca1b6186eaef2b9c 
>   server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java PRE-CREATION

>   server/src/main/webapp/WEB-INF/web.xml d31120a367329a7868e64e4215c168bedaf3aac7 
>   shell/pom.xml 947eab02b229f734640c30de3a7d45ba86656d58 
> 
> Diff: https://reviews.apache.org/r/26931/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message