sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 26941: SQOOP-1557: SQ_CONFIGURABLE ( for entities who own configs)
Date Tue, 21 Oct 2014 22:19:14 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26941/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 3:19 p.m.)


Review request for Sqoop.


Changes
-------

fix tests that was failing with harcoded Driver name


Repository: sqoop-sqoop2


Description
-------

see JIRA for details

there is whitespace, that will be addressed once the reviews for the functionality


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/MConnector.java 174d0b9 
  common/src/main/java/org/apache/sqoop/model/MDriver.java 4241a31 
  core/src/main/java/org/apache/sqoop/driver/Driver.java 46a16ac 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 476830d 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 4c5229f 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 8f78052 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java ff9e0c3 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java
40dcc49 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
3e4a4a9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
aa58850 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
59773e1 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
44ec2e3 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
366e4ee 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
68a173b 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java
bbf721f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
a15bda9 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 8cf9cf1 

Diff: https://reviews.apache.org/r/26941/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message