-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27004/#review57729
-----------------------------------------------------------
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
<https://reviews.apache.org/r/27004/#comment98560>
Your removed file LinkConfiguratoin has a note about DERBYREPO-0008. If no input elements
defined in a configuration, derby will complain.
I suggest fix this issue first, and then replace all empty link configuration with EmptyLinkConfiguration.
- Qian Xu
On Oct. 22, 2014, 7:59 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27004/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 7:59 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
> also it fixes a lot of warnings in the code base.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
e63e464
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsDestroyer.java
74b1cb8
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
2c8b6c8
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java
bb5e353
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
660418d
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java
f40459f
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
5d48a29
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java
c0cd336
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
c6d2f90
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
552a751
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
9d177ec
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/EmptyConfig.java
PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/EmptyJobConfiguration.java
PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/EmptyLinkConfiguration.java
PRE-CREATION
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 6d0dcb4
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 665a65b
> spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java d6c186d
> spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 5c48fc3
> spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 57507df
>
> Diff: https://reviews.apache.org/r/27004/diff/
>
>
> Testing
> -------
>
> yes tests pass.
>
>
> Thanks,
>
> Veena Basavaraj
>
>
|