sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "richard zhou" <yixinxiangs...@gmail.com>
Subject Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service
Date Thu, 23 Oct 2014 09:23:12 GMT


> On Oct. 22, 2014, 7:19 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java,
lines 28-34
> > <https://reviews.apache.org/r/26678/diff/5/?file=728669#file728669line28>
> >
> >     If the type is neither of "KERBEROS" nor "SIMPLE" can we try to use it as a
classname and instantiate it?
> >     
> >     I would like to provide user ability to specify their own authentication class
implementation if needed. This one can be probably done in follow up JIRA though :)

Good suggestion, I will create a JIRA for it


> On Oct. 22, 2014, 7:19 p.m., Jarek Cecho wrote:
> > core/pom.xml, lines 62-66
> > <https://reviews.apache.org/r/26678/diff/5/?file=728665#file728665line62>
> >
> >     Can we move the concrete implementation to it's own module? I would prefer not
to introduce hadoop dependency on core.

Could the hadoop dependency be compile instead of provided?
I do not prefer to write a duplicate code to implement this, only because to avoid adding
hadoop dependency.
Could we use reflect (ClassUtils.loadClass)?
Or which component in sqoop could add hadoop dependency? excution? submission? could we move
KerberosAuthenticationHandler to this component or create a security component to add haoop
dependency?


- richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26678/#review57867
-----------------------------------------------------------


On Oct. 22, 2014, 7:44 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26678/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 7:44 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Kerberos support when starting service
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandler.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationHandler.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationHandler.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java ac836c7cee010144696ab17645ccd008aed5762d

>   dist/src/main/server/conf/sqoop.properties bb010166120321899425f84edb8e1ad6512626d2

>   pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 
> 
> Diff: https://reviews.apache.org/r/26678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message