sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <sx.a...@googlemail.com>
Subject Re: Review Request 27004: SQOOP-1554:Add NullConfigurationClass to support use cases that do not have a particular type of config
Date Fri, 24 Oct 2014 04:32:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27004/#review58240
-----------------------------------------------------------



connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
<https://reviews.apache.org/r/27004/#comment99192>

    The patch contains two things: (1) add To/From into class names (2) use `EmptyConfiguration`
instead of an empty `LinkConfiguration`. 
    
    The code itself looks good. The only concern is that if later HDFS has some linked configuration,
we have to change a lot of class references including unittests. 
    
    How about create `LinkConfiguration` as an alias of `EmptyConfiguration`?


- Qian Xu


On Oct. 23, 2014, 4:46 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27004/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 4:46 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA for details.
> 
> also it fixes a lot of warnings in the code base.
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
e63e464 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsDestroyer.java
74b1cb8 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
2c8b6c8 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromDestroyer.java
PRE-CREATION 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java
PRE-CREATION 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java
bb5e353 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
660418d 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java
f40459f 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToDestroyer.java
PRE-CREATION 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java
PRE-CREATION 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
5d48a29 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java
c0cd336 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 9b8c6ba

>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
c6d2f90 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
552a751 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
9d177ec 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/EmptyConfiguration.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java 51e562c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 6d0dcb4 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 665a65b 
>   spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java a133106 
>   spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java d6c186d 
>   spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 5c48fc3 
>   spi/src/main/java/org/apache/sqoop/job/etl/Loader.java cc32ada 
>   spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 57507df 
> 
> Diff: https://reviews.apache.org/r/27004/diff/
> 
> 
> Testing
> -------
> 
> yes tests pass. 
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message