sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <sx.a...@googlemail.com>
Subject Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not working.
Date Sun, 26 Oct 2014 04:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/#review58552
-----------------------------------------------------------



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java
<https://reviews.apache.org/r/27190/#comment99621>

    Prefix "I" for interface does not follow name convention of the project. 
    
    Imagine that when changing from an abstract class to an interface a coding convention
with prefix I implies renaming all the occurrences of the class.


- Qian Xu


On Oct. 25, 2014, 9:44 p.m., Oleksiy Sayankin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27190/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2014, 9:44 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
9fd2e4f 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java
c5faa09 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
ef39cdc 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java
f62339f 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java
3f9aa9b 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
96818ba 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
e10a5b4 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
d55b0f1 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java
aa1c4ff 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java
a7ed6ba 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
a33fa36 
> 
> Diff: https://reviews.apache.org/r/27190/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oleksiy Sayankin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message