sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 27236: SQOOP-1513: Link rest api changes
Date Tue, 28 Oct 2014 04:10:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58763
-----------------------------------------------------------

Ship it!


Almost there... Just a couple of nit pick and you're good I think.


core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
<https://reviews.apache.org/r/27236/#comment99911>

    This doesn't actually have a "throws" statement. Unchecked exceptions typically aren't
placed here.



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/27236/#comment99912>

    Same as above



server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
<https://reviews.apache.org/r/27236/#comment99913>

    Return to 1 line?


- Abraham Elmahrek


On Oct. 28, 2014, 3:48 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3:48 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA for details.
> 
> Note :I just realized that it might really be more work in HUE to have th parent/child
in URLS,
> 
> so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1

>   common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
7f19c28 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java
02b11fc 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
37343d3 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a 
>   server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc 
>   server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174 
>   server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3 
>   server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd 
>   server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009 
>   server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION 
>   server/src/main/webapp/WEB-INF/web.xml a6f7b0d 
> 
> Diff: https://reviews.apache.org/r/27236/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message