-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58770
-----------------------------------------------------------
A few nits here and there buy looks good.
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
<https://reviews.apache.org/r/27248/#comment99927>
There are two underscores.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment99932>
We should probably move a lot of this out to a utility class. Can we address this in another
Jira? Class inheritance works for now.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
<https://reviews.apache.org/r/27248/#comment99931>
configName2 isn't used
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
<https://reviews.apache.org/r/27248/#comment99930>
NIT: Spacing is a little weird
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
<https://reviews.apache.org/r/27248/#comment99929>
NIT: Spacing is a little weird
- Abraham Elmahrek
On Oct. 28, 2014, 5:40 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 5:40 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java
7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
|