sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 27248: SQOOP-1629:Add unique constraint on the Config table for name and type
Date Tue, 28 Oct 2014 06:08:09 GMT


> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java,
line 144
> > <https://reviews.apache.org/r/27248/diff/2/?file=735127#file735127line144>
> >
> >     There are two underscores.

vow that was good catch at night.!


> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java,
line 127
> > <https://reviews.apache.org/r/27248/diff/2/?file=735131#file735131line127>
> >
> >     configName2 isn't used

but this class overrides the base class method. did not want to break that signature


> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java,
line 413
> > <https://reviews.apache.org/r/27248/diff/2/?file=735129#file735129line413>
> >
> >     We should probably move a lot of this out to a utility class. Can we address
this in another Jira? Class inheritance works for now.

yes I will add a comment in the ticket I ahve for test clean up. I jsut saw Chelsoo Park have
the same thing about this test file

https://issues.apache.org/jira/browse/SQOOP-1583


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58770
-----------------------------------------------------------


On Oct. 27, 2014, 10:40 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 10:40 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
e584a19 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
f579b93 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
0bdb4c6 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
edcef70 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
ca40545 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
7f35f8c 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java
7687be7 
> 
> Diff: https://reviews.apache.org/r/27248/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message