-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27274/#review58780
-----------------------------------------------------------
src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java
<https://reviews.apache.org/r/27274/#comment99950>
For better code readibility, consider make code shorter.
OraOopOracleDataChunkMethod method = OraOopUtilities.getOraOopOracleDataChunkMethod(sqoopOptions.getConf();
if (method == OraOopConstants.OraOopOracleDataChunkMethod.PARTITION) {
src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java
<https://reviews.apache.org/r/27274/#comment99949>
Why remove the log? In case of removal, you can remove the variable result, as no other
place actually use it.
src/test/org/apache/sqoop/manager/oracle/ImportTest.java
<https://reviews.apache.org/r/27274/#comment99951>
Can you import some data and validate the records you have imported?
src/test/org/apache/sqoop/manager/oracle/util/OracleData.java
<https://reviews.apache.org/r/27274/#comment99952>
Although `keySql` has a tailing space, but I'd suggest add a leading space before `"using"`.
- Qian Xu
On Oct. 28, 2014, 3:20 p.m., David Robson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27274/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 3:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1632
> https://issues.apache.org/jira/browse/SQOOP-1632
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> If an index organized table is partitioned - we can use the new chunk by partition functionality
on it - so we should add support for this.
> IOTs that are not partitioned will still not be supported by the direct connector.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt a118249
> src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java 9d75666
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java 7fd18a1
> src/test/oraoop/create_users.sql ecaa409
> src/test/oraoop/pkg_tst_product_gen.pbk 0bc7df7
> src/test/oraoop/table_tst_product_part_iot.xml PRE-CREATION
> src/test/org/apache/sqoop/manager/oracle/ImportTest.java d914e3f
> src/test/org/apache/sqoop/manager/oracle/util/OracleData.java 871d317
> src/test/org/apache/sqoop/manager/oracle/util/OracleTableDefinition.java 5a8c42c
>
> Diff: https://reviews.apache.org/r/27274/diff/
>
>
> Testing
> -------
>
> Manually tested partitioned IOT.
> Added automated test to create a partitioned IOT and run an import from it.
> Ensure existing table types still work.
>
>
> Thanks,
>
> David Robson
>
>
|