From dev-return-13383-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Thu Oct 2 16:49:55 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4384417684 for ; Thu, 2 Oct 2014 16:49:55 +0000 (UTC) Received: (qmail 95843 invoked by uid 500); 2 Oct 2014 16:49:55 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 95811 invoked by uid 500); 2 Oct 2014 16:49:55 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 95795 invoked by uid 500); 2 Oct 2014 16:49:54 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 95790 invoked by uid 99); 2 Oct 2014 16:49:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Oct 2014 16:49:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 701F01D9D4D; Thu, 2 Oct 2014 16:49:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6131963194971021023==" MIME-Version: 1.0 Subject: Re: Review Request 26265: SQOOP-1560: Sqoop2: Move matcher out of Schema From: "Gwen Shapira" To: "Abraham Elmahrek" , "Sqoop" , "Gwen Shapira" Date: Thu, 02 Oct 2014 16:49:51 -0000 Message-ID: <20141002164951.18846.74650@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gwen Shapira" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26265/ X-Sender: "Gwen Shapira" References: <20141002164724.19041.93336@reviews.apache.org> In-Reply-To: <20141002164724.19041.93336@reviews.apache.org> Reply-To: "Gwen Shapira" X-ReviewRequest-Repository: sqoop-SQOOP-1367 --===============6131963194971021023== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 2, 2014, 4:47 p.m., Gwen Shapira wrote: > > Ship It! Looks awesome. I wish I thought of this design myself. One possible cleanup: Make getMatchingData take IDF as input and return IDF as output (or maybe even initialize with the IDFs and not schemas?). This will allow cleaning up the part in SqoopMapper where you need two IDFs and looks a bit weird. Can be done later, or even never. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26265/#review55215 ----------------------------------------------------------- On Oct. 2, 2014, 9:52 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26265/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 9:52 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1560 > https://issues.apache.org/jira/browse/SQOOP-1560 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 79708d22c38df8c68c64724c622114c2d874cdec > Author: Abraham Elmahrek > Date: Thu Sep 25 19:51:10 2014 -0700 > > SQOOP-1560: Sqoop2: Move matcher out of Schema > > :100644 100644 2a49221... d6bad87... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > :100644 100644 d98b779... 5ef6fc6... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > :100644 000000 e6b2316... 0000000... D connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/AbstractMatcher.java > :100644 000000 938a5df... 0000000... D connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/LocationMatcher.java > :100644 000000 417c85b... 0000000... D connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/NameMatcher.java > :000000 100644 0000000... 58b709e... A connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > :000000 100644 0000000... 8ab1318... A connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > :000000 100644 0000000... 577b091... A connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java > :000000 100644 0000000... ae89e6c... A connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherFactory.java > :000000 100644 0000000... 69d5ebd... A connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > :100644 100644 3954039... 765bedd... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > :100644 100644 8c88d52... 03d84d4... M execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > :100644 100644 941b31d... 1ebd3e4... M execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > :100644 100644 b5435ff... 1952cbb... M execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > :100644 100644 5662120... 032cc11... M execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > :000000 100644 0000000... 7f9a147... A execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > > > Diffs > ----- > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 2a49221 > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java d98b779 > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/AbstractMatcher.java e6b2316 > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/LocationMatcher.java 938a5df > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/matcher/NameMatcher.java 417c85b > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java PRE-CREATION > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java PRE-CREATION > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java PRE-CREATION > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherFactory.java PRE-CREATION > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java PRE-CREATION > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 3954039 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 8c88d52 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 941b31d > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java PRE-CREATION > > Diff: https://reviews.apache.org/r/26265/diff/ > > > Testing > ------- > > mvn clean verify > > > Thanks, > > Abraham Elmahrek > > --===============6131963194971021023==--