From dev-return-13399-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Thu Oct 2 20:58:30 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D872B1743F for ; Thu, 2 Oct 2014 20:58:30 +0000 (UTC) Received: (qmail 44123 invoked by uid 500); 2 Oct 2014 20:58:30 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 44085 invoked by uid 500); 2 Oct 2014 20:58:30 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 44074 invoked by uid 500); 2 Oct 2014 20:58:30 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 44070 invoked by uid 99); 2 Oct 2014 20:58:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Oct 2014 20:58:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 300DA1DDBFE; Thu, 2 Oct 2014 20:58:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4316996484275249527==" MIME-Version: 1.0 Subject: Re: Review Request 26280: SQOOP-1403 From: "Keegan Witt" To: "Sqoop" , "Keegan Witt" Date: Thu, 02 Oct 2014 20:58:27 -0000 Message-ID: <20141002205827.19177.71350@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Keegan Witt" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26280/ X-Sender: "Keegan Witt" References: <20141002205821.19177.6163@reviews.apache.org> In-Reply-To: <20141002205821.19177.6163@reviews.apache.org> Reply-To: "Keegan Witt" X-ReviewRequest-Repository: sqoop-trunk --===============4316996484275249527== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26280/ ----------------------------------------------------------- (Updated Oct. 2, 2014, 4:58 p.m.) Review request for Sqoop. Repository: sqoop-trunk Description ------- SQOOP-1403_3.patch review Diffs ----- COMPILING.txt 138dc0a src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91 src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2 src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION Diff: https://reviews.apache.org/r/26280/diff/ Testing ------- * Tested against our (eBay Enterprise's) SQL Server instances by including these changes in a jar that I forced to be first on the classpath. * Successfully ran new unit and integration tests. Thanks, Keegan Witt --===============4316996484275249527==--