From dev-return-13918-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Mon Oct 13 15:12:27 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D716B176AD for ; Mon, 13 Oct 2014 15:12:27 +0000 (UTC) Received: (qmail 38281 invoked by uid 500); 13 Oct 2014 15:12:27 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 38247 invoked by uid 500); 13 Oct 2014 15:12:27 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 38232 invoked by uid 500); 13 Oct 2014 15:12:27 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 38227 invoked by uid 99); 13 Oct 2014 15:12:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Oct 2014 15:12:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E8E0B1D352C; Mon, 13 Oct 2014 15:12:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6238583545997593433==" MIME-Version: 1.0 Subject: Re: Review Request 26592: SQOOP-1566: Fix the upgrade logic for SQOOP-1498 From: "Veena Basavaraj" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" Date: Mon, 13 Oct 2014 15:12:22 -0000 Message-ID: <20141013151222.24413.95333@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Veena Basavaraj" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26592/ X-Sender: "Veena Basavaraj" References: <20141012190618.24414.19122@reviews.apache.org> In-Reply-To: <20141012190618.24414.19122@reviews.apache.org> Reply-To: "Veena Basavaraj" X-ReviewRequest-Repository: sqoop-sqoop2 --===============6238583545997593433== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 12, 2014, 12:06 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java, lines 34-35 > > > > > > Could we move these renames to a different Jira? JobConstants is used all over the execution framework, which seems to be separate from the repository changes. I thought in our dicsussion earlier we agreed to get this done, I would appreciate if you can stick to your original decisions. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26592/#review56358 ----------------------------------------------------------- On Oct. 10, 2014, 9:27 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26592/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 9:27 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > - Mainly fix the upgrade logic for 1498 changes > - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. > > - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs > - rename mapreduce to MR ( if this is not acceptable, happy to change it back) > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 9e762dc > common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION > common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION > common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 > common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e > common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 > common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e > common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java d5377f8 > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION > core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 > core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb > core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d > core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION > core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab > core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 > core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d > core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 > core/src/main/resources/driver-config.properties.rej PRE-CREATION > core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 > core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION > core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 > execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 > execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION > execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION > execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 10a7b1a > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java cf6e657 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 56ea147 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 9316687 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java fc95222 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 260c2a9 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 01a05b2 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java bbfe5bb > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 8402d8c > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 > server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 > shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java a1bc5d5 > spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION > spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 5315e1f > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java f89c546 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 76ebd3b > > Diff: https://reviews.apache.org/r/26592/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > > --===============6238583545997593433==--