From dev-return-14048-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Fri Oct 17 03:53:09 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC9E110881 for ; Fri, 17 Oct 2014 03:53:09 +0000 (UTC) Received: (qmail 81966 invoked by uid 500); 17 Oct 2014 03:53:09 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 81913 invoked by uid 500); 17 Oct 2014 03:53:09 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 81902 invoked by uid 500); 17 Oct 2014 03:53:09 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 81897 invoked by uid 99); 17 Oct 2014 03:53:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 03:53:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A54171DF410; Fri, 17 Oct 2014 03:53:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6367969556960663191==" MIME-Version: 1.0 Subject: Re: Review Request 26581: SQOOP-1156: HBase connector TO direction From: "Qian Xu" To: "Abraham Elmahrek" , "Qian Xu" , "Sqoop" Date: Fri, 17 Oct 2014 03:53:04 -0000 Message-ID: <20141017035304.24426.96925@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Qian Xu" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26581/ X-Sender: "Qian Xu" References: <20141010233522.24817.33363@reviews.apache.org> In-Reply-To: <20141010233522.24817.33363@reviews.apache.org> Reply-To: "Qian Xu" X-ReviewRequest-Repository: sqoop-sqoop2 --===============6367969556960663191== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26581/#review57100 ----------------------------------------------------------- connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java Shall we close the connection explicitly? https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HConnectionManager.html#createConnection(org.apache.hadoop.conf.Configuration) >> his bypasses the usual HConnection life cycle management done by getConnection(Configuration). The caller is responsible for calling Connection.close() on the returned connection instance. This is the recommended way to create HConnections. - Qian Xu On Oct. 11, 2014, 7:35 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26581/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2014, 7:35 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1156 > https://issues.apache.org/jira/browse/SQOOP-1156 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7 > Author: Abraham Elmahrek > Date: Thu Oct 9 22:56:34 2014 -0700 > > SQOOP-1156: HBase connector > > :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml > :000000 100644 0000000... b0e4ea0... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java > :000000 100644 0000000... 975cb40... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java > :000000 100644 0000000... 2e08bfd... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java > :000000 100644 0000000... cf632c9... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java > :000000 100644 0000000... bc61993... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java > :000000 100644 0000000... 991846f... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java > :000000 100644 0000000... 325591c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java > :000000 100644 0000000... 51fd885... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java > :000000 100644 0000000... 6e306b1... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java > :000000 100644 0000000... a4b825c... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java > :000000 100644 0000000... 15feb54... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java > :000000 100644 0000000... cc71b78... A connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java > :000000 100644 0000000... 15a9425... A connector/connector-hbase/src/main/resources/hbase-connector-resources.properties > :000000 100644 0000000... 1fc360e... A connector/connector-hbase/src/main/resources/sqoopconnector.properties > :000000 100644 0000000... c78042a... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java > :000000 100644 0000000... 60f8217... A connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java > :000000 100644 0000000... 44ffced... A connector/connector-hbase/src/test/resources/log4j.properties > :100644 100644 e98a0fc... 35c665e... M connector/pom.xml > :100644 100644 f25a29f... a556bcf... M pom.xml > :100644 100644 67baaa5... 21a1fa9... M server/pom.xml > :100644 100644 7a80710... fbd4e84... M test/pom.xml > > > Diffs > ----- > > connector/connector-hbase/pom.xml PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION > connector/connector-hbase/src/main/resources/hbase-connector-resources.properties PRE-CREATION > connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION > connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java PRE-CREATION > connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java PRE-CREATION > connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION > connector/pom.xml e98a0fc > pom.xml f25a29f > server/pom.xml 67baaa5 > test/pom.xml 7a80710 > > Diff: https://reviews.apache.org/r/26581/diff/ > > > Testing > ------- > > mvn clean verify + can transfer from mysql to hbase. > > > Thanks, > > Abraham Elmahrek > > --===============6367969556960663191==--