From dev-return-14052-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org  Fri Oct 17 06:43:46 2014
Return-Path: <dev-return-14052-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org>
X-Original-To: apmail-sqoop-dev-archive@www.apache.org
Delivered-To: apmail-sqoop-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C8E4310BEE
	for <apmail-sqoop-dev-archive@www.apache.org>; Fri, 17 Oct 2014 06:43:46 +0000 (UTC)
Received: (qmail 84611 invoked by uid 500); 17 Oct 2014 06:43:46 -0000
Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org
Received: (qmail 84574 invoked by uid 500); 17 Oct 2014 06:43:46 -0000
Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@sqoop.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@sqoop.apache.org>
List-Post: <mailto:dev@sqoop.apache.org>
List-Id: <dev.sqoop.apache.org>
Reply-To: dev@sqoop.apache.org
Delivered-To: mailing list dev@sqoop.apache.org
Received: (qmail 84560 invoked by uid 500); 17 Oct 2014 06:43:46 -0000
Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org
Received: (qmail 84555 invoked by uid 99); 17 Oct 2014 06:43:46 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 06:43:46 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 9D7431DDE46;
	Fri, 17 Oct 2014 06:43:41 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5818748626895197651=="
MIME-Version: 1.0
Subject: Re: Review Request 26678: SQOOP-1526: Kerberos support when starting
 service
From: "Abraham Elmahrek" <abe@cloudera.com>
To: "Abraham Elmahrek" <abe@cloudera.com>,
 "richard zhou" <yixinxiangshan@gmail.com>,
 "Sqoop" <sqoop-dev@incubator.apache.org>
Date: Fri, 17 Oct 2014 06:43:41 -0000
Message-ID: <20141017064341.24426.10444@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Abraham Elmahrek" <noreply@reviews.apache.org>
X-ReviewGroup: Sqoop
X-ReviewRequest-URL: https://reviews.apache.org/r/26678/
X-Sender: "Abraham Elmahrek" <noreply@reviews.apache.org>
References: <20141017040021.24426.99701@reviews.apache.org>
In-Reply-To: <20141017040021.24426.99701@reviews.apache.org>
Reply-To: "Abraham Elmahrek" <abe@cloudera.com>
X-ReviewRequest-Repository: sqoop-sqoop2

--===============5818748626895197651==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26678/#review57114
-----------------------------------------------------------


For splitting up AuthenticationManager, what I meant was something like the following:
    AuthenticationHandler -> Understands how to do auth.
    AuthenticationManager -> gets AuthenticationHandler using factory and authenticates.
Or something of this nature.

- Abraham Elmahrek


On Oct. 17, 2014, 4 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26678/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 4 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Kerberos support when starting service
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/AuthenticationManagerFactory.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationManager.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationManager.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java ac836c7cee010144696ab17645ccd008aed5762d 
>   dist/src/main/server/conf/sqoop.properties bb010166120321899425f84edb8e1ad6512626d2 
>   pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 
> 
> Diff: https://reviews.apache.org/r/26678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


--===============5818748626895197651==--