From dev-return-14743-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Tue Oct 28 01:47:48 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 879ED17F5E for ; Tue, 28 Oct 2014 01:47:48 +0000 (UTC) Received: (qmail 76889 invoked by uid 500); 28 Oct 2014 01:47:48 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 76845 invoked by uid 500); 28 Oct 2014 01:47:48 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 76834 invoked by uid 500); 28 Oct 2014 01:47:47 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 76828 invoked by uid 99); 28 Oct 2014 01:47:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 01:47:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7A68E1DF7E6; Tue, 28 Oct 2014 01:47:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6630004126892259479==" MIME-Version: 1.0 Subject: Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service From: "richard zhou" To: "Abraham Elmahrek" , "richard zhou" , "Sqoop" Date: Tue, 28 Oct 2014 01:47:52 -0000 Message-ID: <20141028014752.7143.2231@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "richard zhou" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26678/ X-Sender: "richard zhou" References: <20141027200731.7137.43721@reviews.apache.org> In-Reply-To: <20141027200731.7137.43721@reviews.apache.org> Reply-To: "richard zhou" X-ReviewRequest-Repository: sqoop-sqoop2 --===============6630004126892259479== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 27, 2014, 8:07 p.m., Abraham Elmahrek wrote: > > pom.xml, line 218 > > > > > > Where is hadoop-auth being used? It will be used in the second step (SPNEGO process). I will move it to the following review. Because I am working on both tasks simultaneously, it is a mistake to add wrong dependency. - richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review58676 ----------------------------------------------------------- On Oct. 27, 2014, 9:08 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26678/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 9:08 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Kerberos support when starting service > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/core/SqoopServer.java ac836c7cee010144696ab17645ccd008aed5762d > core/src/main/java/org/apache/sqoop/security/AuthenticationConstants.java PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationError.java PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationHandlerFactory.java PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java PRE-CREATION > dist/src/main/server/conf/sqoop.properties bb010166120321899425f84edb8e1ad6512626d2 > pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 > security/pom.xml PRE-CREATION > security/src/main/java/org/apache/sqoop/security/KerberosAuthenticationHandler.java PRE-CREATION > security/src/main/java/org/apache/sqoop/security/SimpleAuthenticationHandler.java PRE-CREATION > server/pom.xml 67baaa57da9f69f2e8795107ca1b6186eaef2b9c > > Diff: https://reviews.apache.org/r/26678/diff/ > > > Testing > ------- > > No test case till now, becasue there is no minikdc lib in support Hadoop 2 version (2.2.0). > For Hadoop 2.2.0, there are only external KDC test cases in Hadoop itself. > For the latest Hadoop version (2.5.1), there is minikdc lib, which makes internal KDC test easily, used by KMS etc. We have mentioned in last regular meeting. > > If internal KDC is a must have, there are 2 options. > 1. write similar minikdc code in SQOOP. > 2. add latest verion of Hadoop (2.5.1) in security component with test scope. (prefered) > > What do you think? Thanks in advance. > > > Thanks, > > richard zhou > > --===============6630004126892259479==--