From dev-return-14810-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Tue Oct 28 06:08:06 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 25FA617711 for ; Tue, 28 Oct 2014 06:08:06 +0000 (UTC) Received: (qmail 50642 invoked by uid 500); 28 Oct 2014 06:08:05 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 50609 invoked by uid 500); 28 Oct 2014 06:08:05 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 50598 invoked by uid 500); 28 Oct 2014 06:08:05 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 50593 invoked by uid 99); 28 Oct 2014 06:08:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 06:08:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E254D1DF7E6; Tue, 28 Oct 2014 06:08:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7528707874658139732==" MIME-Version: 1.0 Subject: Re: Review Request 27248: SQOOP-1629:Add unique constraint on the Config table for name and type From: "Veena Basavaraj" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" Date: Tue, 28 Oct 2014 06:08:09 -0000 Message-ID: <20141028060809.7143.16701@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Veena Basavaraj" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/27248/ X-Sender: "Veena Basavaraj" References: <20141028060421.7137.12254@reviews.apache.org> In-Reply-To: <20141028060421.7137.12254@reviews.apache.org> Reply-To: "Veena Basavaraj" X-ReviewRequest-Repository: sqoop-sqoop2 --===============7528707874658139732== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote: > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java, line 144 > > > > > > There are two underscores. vow that was good catch at night.! > On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote: > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java, line 127 > > > > > > configName2 isn't used but this class overrides the base class method. did not want to break that signature > On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote: > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java, line 413 > > > > > > We should probably move a lot of this out to a utility class. Can we address this in another Jira? Class inheritance works for now. yes I will add a comment in the ticket I ahve for test clean up. I jsut saw Chelsoo Park have the same thing about this test file https://issues.apache.org/jira/browse/SQOOP-1583 - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27248/#review58770 ----------------------------------------------------------- On Oct. 27, 2014, 10:40 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27248/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 10:40 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7 > > Diff: https://reviews.apache.org/r/27248/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > > --===============7528707874658139732==--