From dev-return-13390-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Thu Oct 2 18:57:34 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A6C717C5F for ; Thu, 2 Oct 2014 18:57:34 +0000 (UTC) Received: (qmail 68265 invoked by uid 500); 2 Oct 2014 18:57:34 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 68230 invoked by uid 500); 2 Oct 2014 18:57:34 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 68208 invoked by uid 99); 2 Oct 2014 18:57:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Oct 2014 18:57:34 +0000 Date: Thu, 2 Oct 2014 18:57:33 +0000 (UTC) From: "Veena Basavaraj (JIRA)" To: dev@sqoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SQOOP-1498) Sqoop2: Sqoop2 Repository Object refactoring ( objects prefixed with M) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SQOOP-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156961#comment-14156961 ] Veena Basavaraj edited comment on SQOOP-1498 at 10/2/14 6:56 PM: ----------------------------------------------------------------- updated, tests pass ran mvn clean verify. Use the following to apply. git apply --reject --whitespace=fix /Users/vbasavaraj/Projects/SQOOP-1498.patch was (Author: vybs): updated, tests pass ran mvn clean verify. This patch does not apply to RB for some reason > Sqoop2: Sqoop2 Repository Object refactoring ( objects prefixed with M) > ----------------------------------------------------------------------- > > Key: SQOOP-1498 > URL: https://issues.apache.org/jira/browse/SQOOP-1498 > Project: Sqoop > Issue Type: Improvement > Reporter: Veena Basavaraj > Assignee: Veena Basavaraj > Attachments: SQOOP-1498afterrebase.patch, Sqoop2.pdf > > > See the attached PDF. > Currently there is a lot of overlap with the entity model classes. All the entity model classes in the code are are prefixed with "M" and are under the org.apache.sqoop.model package. > The proposed refactoring will do the following things. > No more MConnectionForms and MJobForms > MConfig( abstract) > FromConfig ( may or may not inherit MConfigList). Still debating if we need a conflg list. We can use a group attribute on the inputs if we need add hierarchy to the config inputs > ToConfig > DriverConfig > FromConfig/ToConfig/DriverConfig entities belongs to a MJob > MInput (MConfig has one or more MInputs) > MConnector will be pretty dumb and will hold its 3 config objects, LinkConfig. FromConfig and ToConfig > MLink belongs to a MConnector > MLink will have a reference to connector and the link config. There will be no connector/ framework part. > MSubmisssion belongs to a MJob > Lastly, the Repository schema will also be renamed to reflect the context/link/driver/jobrun changes > End of Story! -- This message was sent by Atlassian JIRA (v6.3.4#6332)