sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 27330: SQOOP-1510:JobRequestHandler for submit/abort job and SubmissionHandler changes
Date Mon, 03 Nov 2014 04:03:43 GMT


> On Oct. 30, 2014, 10:26 p.m., Qian Xu wrote:
> > client/src/main/java/org/apache/sqoop/client/SqoopClient.java, line 460
> > <https://reviews.apache.org/r/27330/diff/7/?file=743043#file743043line460>
> >
> >     The original `first` is more straightforward to understand
> 
> Veena Basavaraj wrote:
>     explain why, the reason it is changed it because, there is a enum on the client that
holds the status and it was called "SUBMITTED"/ UPDATED.  the java doc was missed, what it
really meant it started. since we want to use Start.
>     
>     I encourage you spend some time readinf the JIRA and the code, there is so much inconsistency
between submit and start, done over time and I am trying to fix it.

I have moved this discussion to a new JIRA as to why we have 2 enums and how we can use submit/start
consistently

https://issues.apache.org/jira/browse/SQOOP-1652


> On Oct. 30, 2014, 10:26 p.m., Qian Xu wrote:
> > common/src/main/java/org/apache/sqoop/json/JobBean.java, line 114
> > <https://reviews.apache.org/r/27330/diff/7/?file=743048#file743048line114>
> >
> >     I see you new an array and passed in. How about changing `void` to `JSONArray`?
I'm afraid that when you passing an array and you cannot garantee existing elementes are not
modified.
> 
> Veena Basavaraj wrote:
>     I rather not do this in this RB, since there are other places that follow this a
pattern that was shipped, file a ticket so I can consistently change it all places

fixed in this RB for jobs/submisisons


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59303
-----------------------------------------------------------


On Nov. 2, 2014, 6:47 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 6:47 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA and its parent JIRA for details
> 
> FYI : it does nto include the start/submit and stop/abort renames.
> 
> new tickets have been added to address these
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c 
>   client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3

>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7

>   client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java
5055783 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591 
>   common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338 
>   common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf 
>   core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
b324f4f 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java
c894d06 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c

>   server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237 
>   server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883 
>   server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION

>   server/src/main/webapp/WEB-INF/web.xml 6ad90d2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION

>   shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965 
>   shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87 
>   shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
>   shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
36f7443 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68 
> 
> Diff: https://reviews.apache.org/r/27330/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message