sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 27312: SQOOP-1469 Sqoop2: Validations: Rename class Status to Severity
Date Mon, 03 Nov 2014 16:01:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27312/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 4:01 p.m.)


Review request for Sqoop.


Changes
-------

With further exploring what all APIs I'm changing by the rename and taking into account Veena's
feedback, I've decided not to rename the class from "Status" to "Severity" but just rename
the internal constants to more obvious ones.


Bugs: SQOOP-1469
    https://issues.apache.org/jira/browse/SQOOP-1469


Repository: sqoop-sqoop2


Description
-------

This page is getting crazy big, but only contains the following change(s):

* Renamed class Status to Severity
* Renamed "FINE" to "OK"
* Renamed "ACCEPTABLE" to "WARNING"
* Renamed "UNACCEPTABLE" to "ERROR"

Which were suggestions that were there for quite some time.


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/validation/Status.java 5a546bf 
  common/src/main/java/org/apache/sqoop/validation/validators/ClassAvailable.java 52a8fdd

  common/src/main/java/org/apache/sqoop/validation/validators/Contains.java 8920c72 
  common/src/main/java/org/apache/sqoop/validation/validators/NotEmpty.java 248a2fa 
  common/src/main/java/org/apache/sqoop/validation/validators/NotNull.java 93b5fa7 
  common/src/main/java/org/apache/sqoop/validation/validators/NullOrContains.java 9d11a2e

  common/src/main/java/org/apache/sqoop/validation/validators/StartsWith.java 808e1f7 
  common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java bdbad72 
  common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java a75a7cd 
  common/src/test/java/org/apache/sqoop/validation/TestStatus.java 99d8076 
  common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 579d1c5 
  common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java 3a15274

  common/src/test/java/org/apache/sqoop/validation/validators/TestContains.java e63a69a 
  common/src/test/java/org/apache/sqoop/validation/validators/TestNotEmpty.java 5c9169a 
  common/src/test/java/org/apache/sqoop/validation/validators/TestNotNull.java 91e5398 
  common/src/test/java/org/apache/sqoop/validation/validators/TestNullOrContains.java 88347eb

  common/src/test/java/org/apache/sqoop/validation/validators/TestStartsWith.java 8c4f9e0

  common/src/test/java/org/apache/sqoop/validation/validators/TestValidator.java 3f60ee6 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
e6e8ed4 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java
be86855 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java
3e55505 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
faf553d 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
c63f8a8 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
7fb1f74 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java a1e734e 
  shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 8188831 
  shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java c1a4f55 
  shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 6f136b2 
  shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java ce9988f 
  shell/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.java da26153 
  shell/src/main/java/org/apache/sqoop/shell/DeleteLinkFunction.java c81917e 
  shell/src/main/java/org/apache/sqoop/shell/DisableJobFunction.java 9e46804 
  shell/src/main/java/org/apache/sqoop/shell/DisableLinkFunction.java 6b85292 
  shell/src/main/java/org/apache/sqoop/shell/EnableJobFunction.java 8575a84 
  shell/src/main/java/org/apache/sqoop/shell/EnableLinkFunction.java 1dd30e8 
  shell/src/main/java/org/apache/sqoop/shell/SetOptionFunction.java ccc067f 
  shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java 84df281 
  shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d605457 
  shell/src/main/java/org/apache/sqoop/shell/ShowDriverFunction.java 080792b 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 0640283 
  shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f4eae33 
  shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java 4bb0cab 
  shell/src/main/java/org/apache/sqoop/shell/ShowServerFunction.java 67eb6a6 
  shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 2d00b88 
  shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java 3b4bb3f 
  shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05 
  shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3 
  shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500 
  shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java dea271a 
  shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java c61d33b 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3 

Diff: https://reviews.apache.org/r/27312/diff/


Testing
-------

Unit tests are passing.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message