sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 27543: DOC: Connector SDK docs + validation to be updated
Date Tue, 04 Nov 2014 03:25:17 GMT


> On Nov. 4, 2014, 3:08 a.m., Jarek Cecho wrote:
> > docs/src/site/sphinx/ConnectorDevelopment.rst, line 129
> > <https://reviews.apache.org/r/27543/diff/2/?file=748012#file748012line129>
> >
> >     We should not be talking about a Mapreduce job here - that is specific to the
execution engine. I would say that initializer is executed first before any other action.
> 
> Veena Basavaraj wrote:
>     agree. you are ok wit removing it, it existed before.

Yes, I'm OK with removing it.


> On Nov. 4, 2014, 3:08 a.m., Jarek Cecho wrote:
> > docs/src/site/sphinx/ConnectorDevelopment.rst, line 165
> > <https://reviews.apache.org/r/27543/diff/2/?file=748012#file748012line165>
> >
> >     Let's not confuse the connector developer with Driver here. Let's just state
that they are suppose to create 0..N partitions where N is driven by user.
> >     
> >     Similarly I don't think that we should talk about mappers and reducers here
as that is a specific to one single execution engine (albeit the only one right now). Perhaps
we can add some explanation block to say "hey in MR exec engine it's implemented this way"
as an example?
> 
> Veena Basavaraj wrote:
>     sure I will use the example patterm. Since at tne end of this doc, we clearly show
how MR is used

Yeah and that portion seems to be useful as an example :)


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27543/#review59718
-----------------------------------------------------------


On Nov. 4, 2014, 3:07 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27543/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 3:07 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I have taken liberty to write some stuff, happy to amend it!
> 
> 
> I will remove the WS once the cotnents are approved. Typing some of this at the qcon:)
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/ConnectorDevelopment.rst e4b5402 
> 
> Diff: https://reviews.apache.org/r/27543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message