sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 27589: SQOOP-1676: DOC: clientAPI.rst changes to reflect latest code
Date Tue, 04 Nov 2014 22:29:09 GMT


> On Nov. 4, 2014, 2:24 p.m., Gwen Shapira wrote:
> > docs/src/site/sphinx/Tools.rst, line 27
> > <https://reviews.apache.org/r/27589/diff/2/?file=749720#file749720line27>
> >
> >     accidental change?

it was broken in the UI some new line error.


> On Nov. 4, 2014, 2:24 p.m., Gwen Shapira wrote:
> > docs/src/site/sphinx/ClientAPI.rst, lines 148-150
> > <https://reviews.apache.org/r/27589/diff/2/?file=749718#file749718line148>
> >
> >     So I need to know these configs will exist when I try to use the API? How do
I find those?

there is  section below to get them, I will link it


> On Nov. 4, 2014, 2:24 p.m., Gwen Shapira wrote:
> > docs/src/site/sphinx/ClientAPI.rst, line 119
> > <https://reviews.apache.org/r/27589/diff/2/?file=749718#file749718line119>
> >
> >     I think mentioning connectors here is a bit confusing. The API works with configs
and links, so bringing connectors to the introduction can cause a confusion between links
and connectors.

A link is associated with connector. 

let me simplify a bit.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27589/#review59850
-----------------------------------------------------------


On Nov. 4, 2014, 2:25 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27589/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 2:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1676
>     https://issues.apache.org/jira/browse/SQOOP-1676
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/ClientAPI.rst 7293716 
>   docs/src/site/sphinx/ConnectorDevelopment.rst 5e61943 
>   docs/src/site/sphinx/Tools.rst 6d36b27 
> 
> Diff: https://reviews.apache.org/r/27589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message