sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 27589: SQOOP-1676: DOC: clientAPI.rst changes to reflect latest code
Date Tue, 04 Nov 2014 23:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27589/#review59865
-----------------------------------------------------------

Ship it!


Watch white spaces as well.


docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/27589/#comment101173>

    "and delete link" => "and delete a link"
    "Creating or updating link" => "Creating or updating a link"



docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/27589/#comment101175>

    "new linkId" => "a new link Id"



docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/27589/#comment101176>

    "for that connector.A" => "for that connector. A"
    
    "A connector can one or more links." => "A connector can have one or more links."???
    
    "And for every such link can have one or more job config objects for each of the direction
``From`` and ``To``."?? I thought job configs are part of the Job, not link?



docs/src/site/sphinx/ClientAPI.rst
<https://reviews.apache.org/r/27589/#comment101177>

    "Above code block" => "In the above code block"
    
    "Polltime" => "Poll time" or "`pollTime`".


- Abraham Elmahrek


On Nov. 4, 2014, 11:18 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27589/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:18 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1676
>     https://issues.apache.org/jira/browse/SQOOP-1676
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/ClientAPI.rst 7293716 
>   docs/src/site/sphinx/ConnectorDevelopment.rst 5e61943 
>   docs/src/site/sphinx/Tools.rst 6d36b27 
> 
> Diff: https://reviews.apache.org/r/27589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message