sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 27589: SQOOP-1676: DOC: clientAPI.rst changes to reflect latest code
Date Tue, 04 Nov 2014 23:37:28 GMT


> On Nov. 4, 2014, 3:34 p.m., Abraham Elmahrek wrote:
> > Watch white spaces as well.

some how they dont matter in this IDE, so I am saving my energy:)


> On Nov. 4, 2014, 3:34 p.m., Abraham Elmahrek wrote:
> > docs/src/site/sphinx/ClientAPI.rst, line 123
> > <https://reviews.apache.org/r/27589/diff/4/?file=749760#file749760line123>
> >
> >     "for that connector.A" => "for that connector. A"
> >     
> >     "A connector can one or more links." => "A connector can have one or more
links."???
> >     
> >     "And for every such link can have one or more job config objects for each of
the direction ``From`` and ``To``."?? I thought job configs are part of the Job, not link?

a connector has one or more links ( since a link is associated with a connector - FK)
i will reword the second line, all I meant it that we can create as many job configs as we
want for a link object.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27589/#review59865
-----------------------------------------------------------


On Nov. 4, 2014, 3:18 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27589/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 3:18 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1676
>     https://issues.apache.org/jira/browse/SQOOP-1676
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/ClientAPI.rst 7293716 
>   docs/src/site/sphinx/ConnectorDevelopment.rst 5e61943 
>   docs/src/site/sphinx/Tools.rst 6d36b27 
> 
> Diff: https://reviews.apache.org/r/27589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message