sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <sx.a...@googlemail.com>
Subject Review Request 27608: SQOOP-1669: JDBC connector does not understand iso8610 representation using " " as separator
Date Wed, 05 Nov 2014 04:45:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27608/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1669
    https://issues.apache.org/jira/browse/SQOOP-1669


Repository: sqoop-sqoop2


Description
-------

I have a mysql table. Record value of a datetime field is "2014-11-04 00:11:22.3". But {{LocalDateTime.parse(s)}}
thinks it is malformed. It has no problem to parse "2014-11-04T00:11:22.3". 

The root cause is that joda-time will only parse datetime string that fits ISO8601. And a
space is not a standard datetime separator. Unfortunately, in the real world, database (i.e.
mysql, postgres) might send a malformed datatime string. The patch intends to handle the case.


Diffs
-----

  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
7eb1d8d 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
74f2e07 

Diff: https://reviews.apache.org/r/27608/diff/


Testing
-------

A new test case is added


Thanks,

Qian Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message