sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 26276: SQOOP2: rename Type to Column Type+ minor doc fixes
Date Mon, 10 Nov 2014 23:53:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/
-----------------------------------------------------------

(Updated Nov. 10, 2014, 3:53 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1703
    https://issues.apache.org/jira/browse/SQOOP-1703


Repository: sqoop-SQOOP-1367


Description
-------

ssee jira.

rename type to column type ( since it is enum representing columns)
rename size on stirng to length, again a nitpick, since it is in line with java string class

No functional change


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932 
  common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea 
  common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java d84c7ec 
  common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e 
  common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8 
  common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf 
  common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303 
  common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe 
  common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328 
  common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab 
  common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048 
  common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1 
  common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011 
  common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8 
  common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f 
  common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6 
  common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0 
  common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8 
  common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
e65edd9 

Diff: https://reviews.apache.org/r/26276/diff/


Testing
-------


Thanks,

Veena Basavaraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message