sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 28373: SQOOP-1783 Sqoop2: Create derby integration upgrade tests
Date Mon, 24 Nov 2014 23:15:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28373/#review62894
-----------------------------------------------------------



test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java
<https://reviews.apache.org/r/28373/#comment105030>

    rename this to connectorUpgradeProperty ( configuration is overloaded term in sqoop_
    
    It is not a connector configuration. I understand why you have named it this way since
there are other places, if you can possiblu change all others its good.



test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
<https://reviews.apache.org/r/28373/#comment105031>

    Will we add a test per repository? in that case please create a ticket for post gres since
that is important to have before we call the post gres repo work done.
    
    Please rename this class to reflect the below, 
    
    It is not testing repository schema upgrade, it should be exercising the upgradeConnector
nd upgradeDriver code in the Respository.java.
    
    So please plug the word data into.
    
    Please add these comments explaining what this test case does, so someone new can really
understand it
    
    DerbyRepoDataUpgrade seems more apt.



test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
<https://reviews.apache.org/r/28373/#comment105040>

    can we have any more assert here to say that the upgrade actually kicked off, some version
assertion?


- Veena Basavaraj


On Nov. 22, 2014, 6:24 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28373/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 6:24 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1783
>     https://issues.apache.org/jira/browse/SQOOP-1783
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've added automated test as suggested on the JIRA.
> 
> You need to put archive derby-repository-1.99.4.tar.gz that is attached to JIRA to path
test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz in order to verify
this patch.
> 
> 
> Diffs
> -----
> 
>   pom.xml e626c7d 
>   test/pom.xml cafa250 
>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4322b1c

>   test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 5e1d564 
>   test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java PRE-CREATION 
>   test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java
PRE-CREATION 
>   test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
PRE-CREATION 
>   test/src/test/resources/repository/derby/derby-repository-1.99.4.tar.gz PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/28373/diff/
> 
> 
> Testing
> -------
> 
> The new test is passing!
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message