sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 28139: Support Time and List Type in CSV IDF
Date Sat, 29 Nov 2014 15:32:34 GMT


> On Nov. 28, 2014, 5:27 p.m., Abraham Elmahrek wrote:
> > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java,
line 355
> > <https://reviews.apache.org/r/28139/diff/7-8/?file=776415#file776415line355>
> >
> >     Can we test nested array case as well?
> >     Object in - Text out
> >     Object in - Object out
> >     Text in - Object out
> >     Text in - Text out
> 
> Veena Basavaraj wrote:
>     I will for sure, just noticed that such echaustive ones are missing for date time
and bit use cases. We should create a ticket to add those as well,
> 
> Veena Basavaraj wrote:
>     Note, the 4 combinations were added for the Array fo strings and not for all the
array types, since it is the exact code path
>     
>     I have added the it for the nested case as you requested

ticket added for bit/ date time.

https://issues.apache.org/jira/browse/SQOOP-1817


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28139/#review63273
-----------------------------------------------------------


On Nov. 28, 2014, 8:01 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28139/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2014, 8:01 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1749
>     https://issues.apache.org/jira/browse/SQOOP-1749
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA
> 
> Arrays/ Nested/ Set
> 
> The latest rev does not have time related changed, it is separate ticket
> See SQOOP-1771 for the detail of the JSON format.
> 
> 
> NOTE: WS will be addressed once the patch is reviewed for functionality and this needs
a rebase since I have other patches pending review that overlap.
> 
> 
> Diffs
> -----
> 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
39a01c1 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
5ef6fc6 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
4d41679 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
fcf6c3c 
> 
> Diff: https://reviews.apache.org/r/28139/diff/
> 
> 
> Testing
> -------
> 
> yes unit tests added. 
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message