sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1651) Sqoop2: Cleanup: Naming and ordering of methods in Repo relates classes
Date Sun, 02 Nov 2014 18:03:34 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193939#comment-14193939
] 

Hudson commented on SQOOP-1651:
-------------------------------

FAILURE: Integrated in Sqoop2-hadoop100 #639 (See [https://builds.apache.org/job/Sqoop2-hadoop100/639/])
SQOOP-1651: Sqoop2: Cleanup: Naming and ordering of methods in Repo relates classes (abraham:
https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=eda0858956cef2d8190065cb4b16647a35623a98)
* repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
* core/src/main/java/org/apache/sqoop/repository/Repository.java
* core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
* repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
* core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
* core/src/main/java/org/apache/sqoop/driver/JobManager.java


> Sqoop2: Cleanup: Naming and ordering of methods in Repo relates classes
> -----------------------------------------------------------------------
>
>                 Key: SQOOP-1651
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1651
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 2.0.0
>
>         Attachments: SQOOP-1651.patch
>
>
> this RB has 2 changes.
> for clarity in reading ( and forward thinking to separate the repo apis per entity so
multiple repo support becomes easier) I group the link related and job related methods together
> Second, all the methods have the verb and then the noun convention.
> Except the 2 methods I have renamed them to be consistent, so it is clear than when a
new methods is added we do not fight over naming conventions. Going forward we will document
the coding guidelines for the sqoop code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message