sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1795) Sqoop2: Retrieve Http post data in plausible manner
Date Mon, 24 Nov 2014 17:46:13 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223193#comment-14223193
] 

Veena Basavaraj commented on SQOOP-1795:
----------------------------------------

The answer is simple, you cannot predict everywhere in the code on the order in which these
methods will be called in future. Not sure what is not coming across here:) 


> Sqoop2: Retrieve Http post data in plausible manner
> ---------------------------------------------------
>
>                 Key: SQOOP-1795
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1795
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Qian Xu
>            Assignee: Qian Xu
>             Fix For: 1.99.5
>
>
> The situation of dealing with the post data is very tricky IMHO. 
> 1. {{getRequest().getReader()}} must be called at the first place. As reading position
cannot be reset, you might get unexpected result without notice. SQOOP-1784 is a case of the
situation.
> 2. Sqoop client sends post data as a JSON object rather than query string format. Usually
it'd suggest to wrap the JSON object as value, and key can be named as "jsonObject". The server
will call {{ctx.getParameterValue("jsonObject")}} to get the value.
> I'd suggest to have a {{getRawPostData()}}, so that callers can put finger away from
{{getReader()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message