sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 28595: Date and DateTime is not encoded in Single Quotes
Date Tue, 02 Dec 2014 15:55:13 GMT


> On Dec. 1, 2014, 10:04 p.m., Jarek Cecho wrote:
> > The patch looks good to me.
> > 
> > Integration test PartitionerTest is failing on my local computer, so I have to investigate
whether it's environmental or not before I can commit it myself.
> 
> Veena Basavaraj wrote:
>     This is one test I usually skip since it eats away my CPU ..!
>     
>     looks like the tests used date time so I missed changing the expected. . I am updating
the tests and a new patch

Looks like this is more convuluted change that I expected. The generic JDBC connector needs
to encode dates in quotes I suppose.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28595/#review63493
-----------------------------------------------------------


On Dec. 2, 2014, 7 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28595/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 7 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1815
>     https://issues.apache.org/jira/browse/SQOOP-1815
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
bd0fbf0 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
75fe429 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
824a51d 
> 
> Diff: https://reviews.apache.org/r/28595/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message