sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 28595: Date and DateTime is not encoded in Single Quotes
Date Tue, 02 Dec 2014 21:40:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28595/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 1:40 p.m.)


Review request for Sqoop.


Changes
-------

added more unit tests to make sure all the combinations are tested for date and date time,
but the issue of partition test failing still exists.

the issue seems to be like the real exception is swallowed and assertion failure instead happens.

It needs more investigation


Bugs: SQOOP-1815
    https://issues.apache.org/jira/browse/SQOOP-1815


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs (updated)
-----

  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
bd0fbf0 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
75fe429 
  test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java d8f2b8d 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
824a51d 

Diff: https://reviews.apache.org/r/28595/diff/


Testing
-------

yes


Thanks,

Veena Basavaraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message