sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 28782: Make DateTime Column type support datetime with and without timezone
Date Mon, 08 Dec 2014 17:23:15 GMT


> On Dec. 7, 2014, 11:29 a.m., Abraham Elmahrek wrote:
> > LGTM.
> > 
> > IMO the most important part of the story is being able to add to this over time.
For instance, maybe we can support multiple formats of dates, times, and timestamps in text
eventually. Also, we should be able to add a transformation layer that can remove timezone
information if needed if we so choose to make all timestamps that don't include timezone information
simply have UTC offset.

Sure, need more elaborate definition and design, i'd like to see a proposal for this for future.


> On Dec. 7, 2014, 11:29 a.m., Abraham Elmahrek wrote:
> > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java,
line 70
> > <https://reviews.apache.org/r/28782/diff/1/?file=784391#file784391line70>
> >
> >     TIMESTAMP should have timezone information?

not sure the line matches, did not understand the comment


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28782/#review64186
-----------------------------------------------------------


On Dec. 5, 2014, 7:35 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28782/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 7:35 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOO-1845
>     https://issues.apache.org/jira/browse/SQOO-1845
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 2f5fadc 
>   common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 791542a 
>   common/src/main/java/org/apache/sqoop/schema/type/Time.java 9765eab 
>   common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 3d31600

>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java
9d50dc3 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
daa51eb 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
e66c897 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f4f5561 
> 
> Diff: https://reviews.apache.org/r/28782/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message