sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 28828: IDF API changes
Date Tue, 09 Dec 2014 14:48:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28828/#review64374
-----------------------------------------------------------


Overall it looks good, I do have several questions though:


connector/connector-generic-jdbc/pom.xml
<https://reviews.apache.org/r/28828/#comment107036>

    The generic JDBC connector seems to be already depending on connector-sdk, so I'm assuming
that this is not necessary?



core/pom.xml
<https://reviews.apache.org/r/28828/#comment107033>

    Wondering why is core depending on joda-time directly?



core/pom.xml
<https://reviews.apache.org/r/28828/#comment107037>

    I'm wondering why would core depend on connector-sdk?



execution/mapreduce/pom.xml
<https://reviews.apache.org/r/28828/#comment107034>

    Wondering why is execution engine depending on connector-sdk?



spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
<https://reviews.apache.org/r/28828/#comment107035>

    I'm wondering why this change? It seems reasonable to have default value.


Jarcec

- Jarek Cecho


On Dec. 9, 2014, 8:17 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28828/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 8:17 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1811
>     https://issues.apache.org/jira/browse/SQOOP-1811
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/pom.xml fc6cab4 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
c233ed5 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
f70142d 
>   connector/connector-kite/pom.xml 10ed099 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java
c864882 
>   connector/connector-sdk/pom.xml 38c217a 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
d6470e6 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java
PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
253dfba 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
4b0dd88 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
3e7c0d1 
>   core/pom.xml 2b6e436 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f4f5561 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java eed79a5 
>   execution/mapreduce/pom.xml b23b905 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java 05b731a

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java b9dd11d

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
49a66b9 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java bbac7d2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java a64a4a6 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java
7c40ad5 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java 5d5359e

>   spi/pom.xml 43f17d4 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java ff6392e 
>   spi/src/main/java/org/apache/sqoop/idf/IntermediateDataFormat.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message