sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 28828: IDF API changes
Date Tue, 09 Dec 2014 15:58:48 GMT


> On Dec. 9, 2014, 6:48 a.m., Jarek Cecho wrote:
> > core/pom.xml, lines 42-44
> > <https://reviews.apache.org/r/28828/diff/3/?file=786499#file786499line42>
> >
> >     Wondering why is core depending on joda-time directly?

jobManaager.


> On Dec. 9, 2014, 6:48 a.m., Jarek Cecho wrote:
> > core/pom.xml, lines 57-59
> > <https://reviews.apache.org/r/28828/diff/3/?file=786499#file786499line57>
> >
> >     I'm wondering why would core depend on connector-sdk?

since there are tests that use CSV


> On Dec. 9, 2014, 6:48 a.m., Jarek Cecho wrote:
> > execution/mapreduce/pom.xml, lines 36-39
> > <https://reviews.apache.org/r/28828/diff/3/?file=786502#file786502line36>
> >
> >     Wondering why is execution engine depending on connector-sdk?

since tests use CSV


> On Dec. 9, 2014, 6:48 a.m., Jarek Cecho wrote:
> > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java, line 95
> > <https://reviews.apache.org/r/28828/diff/3/?file=786511#file786511line95>
> >
> >     I'm wondering why this change? It seems reasonable to have default value.

if we have that then we need to think of how SPI does not deepend on SDK, and it creates a
cyclic dependency


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28828/#review64374
-----------------------------------------------------------


On Dec. 9, 2014, 12:17 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28828/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 12:17 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1811
>     https://issues.apache.org/jira/browse/SQOOP-1811
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/pom.xml fc6cab4 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
c233ed5 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
f70142d 
>   connector/connector-kite/pom.xml 10ed099 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java
c864882 
>   connector/connector-sdk/pom.xml 38c217a 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
d6470e6 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java
PRE-CREATION 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
253dfba 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
4b0dd88 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
3e7c0d1 
>   core/pom.xml 2b6e436 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java f4f5561 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java eed79a5 
>   execution/mapreduce/pom.xml b23b905 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java 05b731a

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java b9dd11d

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
49a66b9 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java bbac7d2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java a64a4a6 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java
7c40ad5 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java 5d5359e

>   spi/pom.xml 43f17d4 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java ff6392e 
>   spi/src/main/java/org/apache/sqoop/idf/IntermediateDataFormat.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message