sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 28795: SQOOP-1776: Delegation Token support for Authentication
Date Wed, 10 Dec 2014 04:33:37 GMT


> On Dec. 8, 2014, 11:41 p.m., Abraham Elmahrek wrote:
> > pom.xml, line 98
> > <https://reviews.apache.org/r/28795/diff/1/?file=785169#file785169line98>
> >
> >     Move to a separate Jira since we do not know what this will do?
> 
> richard zhou wrote:
>     It is my mis-understanding. I thought that the delegation token is in Hadoop 2.5.1,
however actually it is in 2.6.0, but Hadoop 2.6.0 will be supported in sqoop 2 sooner or later.
>     Shall I put this version in sqoop client component only for the time being, and add
todo as comment? Then whenever 2.6.0 is supported in the near future, I could change it back
to the main pom.xml.

Creating a period where client and server are out of sync in terms of Hadoop version seems
a bit strange to me. Also, I have one concern about doing an upgrade in this Jira. If there
are any errors caused by the Hadoop 2.6.0 upgrade, it will be difficult to track down to a
specific commit. For example, I won't be able to just `git reset <hadoop upgrade commit>`
and come to the conclusion that it is the new Hadoop library dependency which is causing some
issues.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28795/#review64312
-----------------------------------------------------------


On Dec. 8, 2014, 1:55 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28795/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 1:55 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Delegation Token support for Authentication.
> It depends on Hadoop 2.6.0+. Currently, Sqoop depends on Hadoop 2.5.1. Not sure whether
there is plan to upgrade Hadoop version from 2.5.1 to 2.6. Anyway, sooner or Later, it will
happen.
> Initial patch with manual test. Integration test will be in another JIRA SQOOP-1633
> 
> 
> Diffs
> -----
> 
>   client/pom.xml b53c9d3d74b7eeb8ff2a64bee1c8f7ec5144c281 
>   client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java 6be1db87f94e1712399f724c740da1416389ba3b

>   common/src/main/java/org/apache/sqoop/common/MapContext.java 2229889ca6fa45f70c938a04576b4c16999f4088

>   dist/src/main/server/conf/sqoop.properties fe4dfb62f74215b1521699cd7612c45d307365c2

>   pom.xml e6ffc78cc332efa36b2a76c609bf37a57aeba1a7 
>   server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java bb6629047f1eaa89b42a3f99384e0f61a51a6b9a

> 
> Diff: https://reviews.apache.org/r/28795/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message