sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 28802: SQOOP-1852: Sqoop2: Kafka connector supporting TO direction
Date Wed, 10 Dec 2014 05:32:59 GMT


> On Dec. 10, 2014, 4:20 a.m., Abraham Elmahrek wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaConsumer.java,
line 64
> > <https://reviews.apache.org/r/28802/diff/2/?file=787466#file787466line64>
> >
> >     10 seconds or 1 second?

Didn't get this comment. 1000ms = 1s. Does it say 10s anywhere?


> On Dec. 10, 2014, 4:20 a.m., Abraham Elmahrek wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/kafka/TestUtil.java, line
93
> > <https://reviews.apache.org/r/28802/diff/2/?file=787468#file787468line93>
> >
> >     Follow up: randomize?

good idea. I'll open a JIRA.


> On Dec. 10, 2014, 4:20 a.m., Abraham Elmahrek wrote:
> > common-test/src/main/java/org/apache/sqoop/common/test/kafka/ZooKeeperLocal.java,
lines 56-60
> > <https://reviews.apache.org/r/28802/diff/2/?file=787469#file787469line56>
> >
> >     LOG.error()?

Dropped this since it will generate way too many log messages.


> On Dec. 10, 2014, 4:20 a.m., Abraham Elmahrek wrote:
> > pom.xml, lines 549-551
> > <https://reviews.apache.org/r/28802/diff/2/?file=787486#file787486line549>
> >
> >     Is it possible to handle this similar to Hadoop (scope provided)?

Not sure we can assume Kafka jars on Sqoop2 server. Checking for opinions with mailing list.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28802/#review64472
-----------------------------------------------------------


On Dec. 9, 2014, 11:31 p.m., Gwen Shapira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28802/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 11:31 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> SQOOP-1852: Sqoop2: Kafka connector supporting TO direction
> 
> 
> Diffs
> -----
> 
>   common-test/pom.xml 9fd671c 
>   common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaConsumer.java PRE-CREATION

>   common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaLocal.java PRE-CREATION

>   common-test/src/main/java/org/apache/sqoop/common/test/kafka/TestUtil.java PRE-CREATION

>   common-test/src/main/java/org/apache/sqoop/common/test/kafka/ZooKeeperLocal.java PRE-CREATION

>   connector/connector-kafka/pom.xml PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnectorErrors.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConstants.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaLoader.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToDestroyer.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToInitializer.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfiguration.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/ToJobConfig.java
PRE-CREATION 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/ToJobConfiguration.java
PRE-CREATION 
>   connector/connector-kafka/src/main/resources/kafka-connector-config.properties PRE-CREATION

>   connector/connector-kafka/src/main/resources/sqoopconnector.properties PRE-CREATION

>   connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestConfigValidator.java
PRE-CREATION 
>   connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestKafkaLoader.java
PRE-CREATION 
>   connector/pom.xml da4ed3e 
>   pom.xml e182176 
>   server/pom.xml 1adcca0 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java dc237b8 
>   test/pom.xml eedb545 
>   test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28802/diff/
> 
> 
> Testing
> -------
> 
> Unit tests only for now.
> 
> 
> Thanks,
> 
> Gwen Shapira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message