sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values
Date Thu, 11 Dec 2014 04:19:07 GMT


> On Dec. 11, 2014, 3:54 a.m., Venkat Ranganathan wrote:
> > Sorry it took some time to come up to speed on the changes.   Looks good.
> 
> Venkat Ranganathan wrote:
>     Abe, there are test failures.   Have you rebased and tested this?
>     
>     Tests in error:
>       testSerialization(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
>       testSensitivityFilter(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
>       testSerialization(org.apache.sqoop.json.TestValidationBean): FINE
>       testId(org.apache.sqoop.json.TestValidationBean): FINE
>       testApplyValidation(org.apache.sqoop.model.TestFormUtils): ACCEPTABLE
>       testMessage(org.apache.sqoop.validation.TestValidation): FINE
>       testInitialization(org.apache.sqoop.validation.TestValidation): FINE
>     
>     Tests run: 214, Failures: 0, Errors: 7, Skipped: 0
> 
> Abraham Elmahrek wrote:
>     I had tested this today. Patch is green on Jira as well... let me try to run tests
real quick.

Tests are passing for me locally.

Perhaps there are some old sqoop jars in your maven cache? Not sure if that would affect things.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64682
-----------------------------------------------------------


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <abraham@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0

>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message