sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 28795: SQOOP-1776: Delegation Token support for Authentication
Date Sat, 13 Dec 2014 01:50:57 GMT


> On Dec. 10, 2014, 3:57 p.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java, line
38
> > <https://reviews.apache.org/r/28795/diff/1/?file=785170#file785170line38>
> >
> >     Had an offline discussion with Richard on this. Apparently this is using an
"unstable" API from Hadoop that's marked as "public". This means it's intended to be used,
but there's no guarantee it won't change through out any Hadoop version. Since we mark Hadoop
packages as "provided", it's possible there will be some runtime exceptions depending on Hadoop
version here.
> >     
> >     It seems Hadoop dependencies should be compile time. I've sent a note to the
mailing list to figure this out.

Richard, can you please change the dependencies from "provided" scope to "compile"?


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28795/#review64548
-----------------------------------------------------------


On Dec. 8, 2014, 1:55 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28795/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 1:55 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Delegation Token support for Authentication.
> It depends on Hadoop 2.6.0+. Currently, Sqoop depends on Hadoop 2.5.1. Not sure whether
there is plan to upgrade Hadoop version from 2.5.1 to 2.6. Anyway, sooner or Later, it will
happen.
> Initial patch with manual test. Integration test will be in another JIRA SQOOP-1633
> 
> 
> Diffs
> -----
> 
>   client/pom.xml b53c9d3d74b7eeb8ff2a64bee1c8f7ec5144c281 
>   client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java 6be1db87f94e1712399f724c740da1416389ba3b

>   common/src/main/java/org/apache/sqoop/common/MapContext.java 2229889ca6fa45f70c938a04576b4c16999f4088

>   dist/src/main/server/conf/sqoop.properties fe4dfb62f74215b1521699cd7612c45d307365c2

>   pom.xml e6ffc78cc332efa36b2a76c609bf37a57aeba1a7 
>   server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java bb6629047f1eaa89b42a3f99384e0f61a51a6b9a

> 
> Diff: https://reviews.apache.org/r/28795/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message