sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masahiro Yamaguchi" <mas...@kcf.biglobe.ne.jp>
Subject Re: Review Request 27268: Staging-table name check don't need using PGBulkloadManager
Date Tue, 16 Dec 2014 01:37:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27268/
-----------------------------------------------------------

(Updated Dec. 16, 2014, 1:37 a.m.)


Review request for Sqoop.


Changes
-------

I delete option check for "--clear-staging-table".
If you want to "DROP TABLE IF EXISTS", you can set "pgbulkload.clear.staging.table" option.


Bugs: SQOOP-1631
    https://issues.apache.org/jira/browse/SQOOP-1631


Repository: sqoop-trunk


Description
-------

If we use PGBulkloadManager, the number of staging-tables equals number of map tasks.
And staging-table's name is decided as follows.

tmpTableName = table + "_" + context.getTaskAttemptID().toString();

ExportTools check staging-table's name, but this check don't need using PGBulkloadManager.


Diffs
-----

  src/java/org/apache/sqoop/tool/ExportTool.java 15ecddf 
  src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java fc5fd6d 

Diff: https://reviews.apache.org/r/27268/diff/


Testing
-------

done PGBulkloadManagerManualTest.


File Attachments (updated)
----------------

SQOOP-1631_3.patch
  https://reviews.apache.org/media/uploaded/files/2014/12/16/a144a739-f65c-4972-a30a-61b5a3a63907__SQOOP-1631_3.patch


Thanks,

Masahiro Yamaguchi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message