sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 26948: SQOOP-1523: Sqoop2: Support for PostgreSQL database for hosting the metadata repository
Date Thu, 18 Dec 2014 21:49:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26948/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 9:49 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1523
    https://issues.apache.org/jira/browse/SQOOP-1523


Repository: sqoop-sqoop2


Description
-------

commit 0702bddfa69f63f56bfc6909dfe1b3e4f3219c6a
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Tue Oct 14 12:05:53 2014 -0700

    Sqoop2: Postgresql repository

:100644 100644 5a8e026... 2c5c972... M  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 f25a29f... 5be6ad9... M  pom.xml
:100644 100644 e3345c4... 8b308c9... M  repository/pom.xml
:000000 100644 0000000... 19f67d4... A  repository/repository-postgresql/pom.xml
:000000 100644 0000000... cdeed35... A  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
:000000 100644 0000000... 872683e... A  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java
:000000 100644 0000000... 93352a6... A  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
:000000 100644 0000000... d1ff898... A  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
:000000 100644 0000000... d70dd86... A  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
:000000 100644 0000000... 31cc6dc... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
:000000 100644 0000000... a8f4242... A  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java
:000000 100644 0000000... 44ffced... A  repository/repository-postgresql/src/test/resources/log4j.properties
:100644 100644 67baaa5... 8ecdd01... M  server/pom.xml


Diffs (updated)
-----

  common-test/pom.xml 609a875 
  common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java 0a12d7b

  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ca590d8 
  pom.xml aa4231e 
  repository/pom.xml 8c95c0e 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
9fa2f9d 
  repository/repository-postgresql/pom.xml PRE-CREATION 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
PRE-CREATION 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java
PRE-CREATION 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
PRE-CREATION 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
PRE-CREATION 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
PRE-CREATION 
  repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
PRE-CREATION 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
PRE-CREATION 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java
PRE-CREATION 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
PRE-CREATION 
  repository/repository-postgresql/src/test/resources/log4j.properties PRE-CREATION 
  server/pom.xml 77477ee 

Diff: https://reviews.apache.org/r/26948/diff/


Testing
-------

Can start Sqoop2 server.
Ran integration tests with PostgreSQL. All pass except partitioning on a boolean column.
Also:
 482  disable link -l 1
 483  show link --all
 484  show link
 485  enable link -l 1
 486  show link
 487  show link --all
 488  show job
 489  show job --all
 490  show connector
 491  show connector --all
 492  help
 493  status job --jid 1
 494  history
 495  start job --jid 1
 496  clone job --jid 1
 497  delete job --jid 2
 498  status job --jid 1
 499  history


Thanks,

Abraham Elmahrek


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message