sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1815) Date and DateTime is not encoded in Single Quotes ( + unit tests)
Date Tue, 02 Dec 2014 23:08:13 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232276#comment-14232276
] 

Veena Basavaraj commented on SQOOP-1815:
----------------------------------------

[~abec] since you originally worked on this ticket, would be nice to get more context on 1561
( since it lacks any description)

Few questions:

1. As the code currently works, it uses JODA time to parse the string to actual JODA time
date object. 
Are we ok with exposing a JODA object instead of plain the java date? Since this going to
exposed to the connectors publically?

2. The current code did not have unit tests that tested setObjectData() to getText(), the
latest patch in RB has those tests,In this scenario we expect the object to be JODA time as
well, since we want to convert this into a string format and encode it in quotes as the CSV
IDF document says: https://cwiki.apache.org/confluence/display/SQOOP/Sqoop2+CSV+Intermediate+representation

But the current JDBCConnector sets a java.sql.Date, I have created another ticket for this,
but this means essentially we would need the connector to create a JODA date object before
doing calling writeArray 

see the corresponding ticket

> Date and DateTime is not encoded in Single Quotes  ( + unit tests)
> ------------------------------------------------------------------
>
>                 Key: SQOOP-1815
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1815
>             Project: Sqoop
>          Issue Type: Sub-task
>          Components: sqoop2-framework
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1815-v2.patch, SQOOP-1815.patch
>
>
> I deem this is a BUG in the current code where the date and date time encoded in single
quotes. 
> Correction: as the bug says, it is not encoded.!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message