sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sqoop QA bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1832) Sqoop2: Enforce that integration test working directory is always in target/ directory
Date Wed, 03 Dec 2014 02:44:12 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232482#comment-14232482
] 

Sqoop QA bot commented on SQOOP-1832:
-------------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12684780/SQOOP-1832.patch against branch
sqoop2.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed
{color:green}SUCCESS:{color} All integration tests passed

Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/691/console

This message is automatically generated.

> Sqoop2: Enforce that integration test working directory is always in target/ directory
> --------------------------------------------------------------------------------------
>
>                 Key: SQOOP-1832
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1832
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.4
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1832.patch
>
>
> I've noticed that on certain executions (for example {{mvn integration-test -pl test}}
we're using OS's temp directory ({{/tmp}} on linux, {{/var/folders/bf/...}} on mac OS X) instead
of the configured {{target/}} directory.
> This is relatively small issue, but I would like to fix it because:
> * The tmp directory is not discoverable in Jenkins, so we can't get to all logs without
SSH to target Jenkins slave
> * {{mvn clean}} won't clean up those files
> * The directory can get reused if one runs the tests twice on single machine (from two
different directories)
> I believe that the problem is that we're defining the [test's temporary directory|https://github.com/apache/sqoop/blob/sqoop2/test/pom.xml#L157]
in the pom file using environmental variable {{sqoop.integration.tmpdir}} conditionally only
in some profiles. We should simply set it in all profiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message