sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1858) Sqoop2: Print out warnings from git apply on output of precommit hook
Date Fri, 12 Dec 2014 04:45:13 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243698#comment-14243698
] 

ASF subversion and git services commented on SQOOP-1858:
--------------------------------------------------------

Commit c3900910f8fd0e86913c3e55e8b59ff7acda2b3f in sqoop's branch refs/heads/sqoop2 from [~abec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=c390091 ]

SQOOP-1858: Sqoop2: Print out warnings from git apply on output of precommit hook

(Jarek Jarcec Cecho via Abraham Elmahrek)


> Sqoop2: Print out warnings from git apply on output of precommit hook
> ---------------------------------------------------------------------
>
>                 Key: SQOOP-1858
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1858
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.4
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1858.patch
>
>
> Currently we only check the return value of executing {{git apply}} and printing it's
stdin/stderr only if the return is not 0. However having warnings (for example trailing whitespace)
won't change the return value and hence those get silently ignored. Hence I would suggest
to enhance the precommit hook to print out the output {{git apply}} in case that it's not
empty to highlight the warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message